Extract private class CookieCredentials #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- No change to tests - No change to public API - In Session::Base, now we can say `creds.remember_me_until` instead of saying `creds[2]`. This is clearly an improvement. - Now we can easily unit-test CookieCredentials. I think there's also a CookieManager waiting to be extracted ..
|
This also gives us a natural place to write some better docs about our cookie format. Specifically, it looks like there are at least three variants: 1, 2, and 3 parts. The 2 and 3 part formats can be produced by |
tiegz
approved these changes
Jan 15, 2019
| end | ||
|
|
||
| class << self | ||
| # @api private |
There was a problem hiding this comment.
Is this method supposed to be private?
There was a problem hiding this comment.
It's ruby-public and api-private. The later (api-private) means that changes to this method will not be considered as breaking.
| @record_id.to_s, | ||
| @remember_me_until&.iso8601 | ||
| ].compact.join(DELIMITER) | ||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creds.remember_me_untilinsteadof saying
creds[2]. This is clearly an improvement.I think there's also a CookieManager waiting to be extracted ..