Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruby 2.7 warning on kwargs changes: #692

Merged

Conversation

alchimere
Copy link

@alchimere alchimere commented Nov 28, 2019

authlogic/lib/authlogic/i18n/translator.rb:11: warning: The last argument is used as the keyword parameter

Explicit kwargs with double splat to be ruby-2.7 ready

 authlogic/lib/authlogic/i18n/translator.rb:11: warning: The last argument is used as the keyword parameter
@alchimere
Copy link
Author

@alchimere alchimere commented Nov 28, 2019

I don't understand why the coverage decreased by 0.01%, I only modified one line that is actually covered. Maybe a coveralls edge case ?

@jaredbeck jaredbeck merged commit 9a14168 into binarylogic:master Dec 2, 2019
1 of 2 checks passed
@jaredbeck
Copy link
Collaborator

@jaredbeck jaredbeck commented Dec 2, 2019

Thanks Yann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants