Implemented merging defaults settings with namespaced settings using default_namespace #16

Open
wants to merge 1 commit into
from

Projects

None yet

1 participant

@ayanko

Hi. Please look at commit c65f38e

tests and documentation is also updated.

Please merge ...

Thx!

@ghost

This is nice, but YAML has the ability to store blacks and reuse them:

defaults: &defaults
adapter: postgresql
encoding: unicode
host: localhost
pool: 30
username: username
password: password

development:
database: name
<<: *defaults

The only benefit I can see to this is the it uses deep_merge, and I don't believe YAML does.

@ayanko

but YAML has the ability to store blacks and reuse them:

Yes I know it.

defaults: &defaults

First its very borring.
Second there is no "default" for another keys that are not explicit defined.

The patch only adds new feature.
It does not break regular settingslogic behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment