Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bundler and Suppressing Errors #27

Merged
5 commits merged into from Jan 6, 2012

Conversation

Projects
None yet
1 participant

Hi Ben,

I really appreciate all the open source tools you've put out there. We've gotten some good mileage from settingslogic at PatientsLikeMe.

We ran into a bug where settings might not be defined properly in different Rails environments when using the Rails environment as a key. This made me wish for an ability to change the settingslogic error handling depending on what Rails environment we're in - raise exceptions in dev/test but return something sensible in production.

To solve this for us, I added a new configuration option to suppress errors, with tests and documentation.

I also added bundler support and a gemfile, to make it easier for me to get the tests running and the dependencies installed to run them.

I'd love to see this pulled into the main gem, but if not - I understand.

Thanks again for publishing the gem!
-Winfield

Winfield Peterson added some commits Jan 5, 2012

Winfield Peterson .gitignore file system bundles. 086cf46
Winfield Peterson Bundlerize gem and upgrade to rspec2 compatibility. 8b688ab
Winfield Peterson Adds ability to suppress all errors.
Errors are not raised when using the [] accessors, but when embedded in a Rails app it only make sense to raise exceptions in dev/test environments and to fail silently in production.
6254489
Winfield Peterson Document new suppress_errors option. 6c1bd3d
Winfield Peterson Fix numbering on example docs. f108bda

@ghost ghost pushed a commit that referenced this pull request Jan 6, 2012

@binarylogic binarylogic Merge pull request #27 from wpeterson/master
Bundler and Suppressing Errors
ff02a80

@ghost ghost merged commit ff02a80 into binarylogic:master Jan 6, 2012

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment