Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix Ruby 1.8.7 Compatibility and Gem Dependencies #29

Merged
2 commits merged into from Jan 6, 2012

Conversation

Projects
None yet
2 participants

Hi Ben,

It looks like settingslogic 2.0.7 is broken for Ruby 1.8.7 based on Issue #28 and my own experience. This seems to be caused by a new gem dependency on ruby-debug19.

I fixed the gemspec to require the right version of ruby-debug based on 1.8.7 vs. 1.9 support.

Additionally, I don't think these should be runtime gem dependencies, but development depencies - so I switched them over.

This fixes 1.8.7 compatibility for me.
-Winfield

Winfield Peterson added some commits Jan 6, 2012

Load ruby-debug vs. ruby-debug19 based on ruby version.
Check the ruby version and conditionally add a runtime dependency on the right
debugging library.

Fixes errors installing gem on pre-1.9 versions of Ruby.
Change gemspec runtime depencies to development dependencies.
We only need these gem dependencies to run the tests, not to load the gem.

ghost pushed a commit that referenced this pull request Jan 6, 2012

Merge pull request #29 from wpeterson/ruby_compat_1.8
Fix Ruby 1.8.7 Compatibility and Gem Dependencies

@ghost ghost merged commit e8dfc73 into binarylogic:master Jan 6, 2012

rymai commented Jan 6, 2012

Are you sure this won't be overwritten when you'll regenerate the .gemspec (since you're using Jeweler)?

I think you might be right, I don't have a lot of experience with Jeweler.

The right answer may be to put all of the gems from the bundle in the :development group so that Jeweler will do the right thing.

rymai commented Jan 6, 2012

I think so, but I personally think Jeweler should be dropped completely and that the .gemspec should be written by hand! :)

@ghost

ghost commented Jan 6, 2012

I agree with rymai, I'll do that.

Thanks guys, sorry to address this at a level below the root cause.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment