Skip to content
This repository

Fix Gemfile/Gemspec #31

Merged
merged 3 commits into from over 2 years ago

2 participants

Winfield Binary Logic
Winfield

Hi Ben,

I took the feedback from the previous pull request and modified the Gemfile:

1) Using development group so Jeweler will generate gemspec w/ add_development_dependency
2) Fixed another bug in rspec/rcov rake tasks I found while testing gemspec generation

Thanks for the patience, sorry I managed to hose the autogenerated config with my addition of the Gemfile.

Hopefully this sets it right.
-Winfield

Winfield Pet... added some commits January 07, 2012
Fix Ruby 1.8 compat in Gemfile w/ development group.
Fix issues with correct ruby-debug include for 1.8 vs. 1.9 compatibility.

Also, group all development gems into a development group so jeweler will auto-generate the gemspec correctly.
19a3e37
Fix rspec/rcov rake tasks.
Adds rcov support back in, fix rake tasks for rspec and rcov.
c7f18a0
Adds rcov to gemfile. 2b6d4ac
Binary Logic binarylogic merged commit d1ffd52 into from January 08, 2012
Binary Logic binarylogic closed this January 08, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 3 unique commits by 1 author.

Jan 07, 2012
Fix Ruby 1.8 compat in Gemfile w/ development group.
Fix issues with correct ruby-debug include for 1.8 vs. 1.9 compatibility.

Also, group all development gems into a development group so jeweler will auto-generate the gemspec correctly.
19a3e37
Fix rspec/rcov rake tasks.
Adds rcov support back in, fix rake tasks for rspec and rcov.
c7f18a0
Adds rcov to gemfile. 2b6d4ac
This page is out of date. Refresh to see the latest.
15  Gemfile
... ...
@@ -1,6 +1,13 @@
1 1
 source "http://rubygems.org"
2 2
 
3  
-gem 'rake'
4  
-gem 'jeweler'
5  
-gem 'rspec', :require => 'spec'
6  
-gem 'ruby-debug19'
  3
+group :development do
  4
+  gem 'rake'
  5
+  gem 'jeweler'
  6
+  gem 'rspec', :require => 'spec'
  7
+  gem 'rcov'
  8
+  if RUBY_VERSION < "1.9"
  9
+    gem 'ruby-debug'
  10
+  else
  11
+    gem 'ruby-debug19'
  12
+  end
  13
+end
25  Gemfile.lock
... ...
@@ -1,7 +1,6 @@
1 1
 GEM
2 2
   remote: http://rubygems.org/
3 3
   specs:
4  
-    archive-tar-minitar (0.5.2)
5 4
     columnize (0.3.6)
6 5
     diff-lcs (1.1.3)
7 6
     git (1.2.5)
@@ -9,9 +8,11 @@ GEM
9 8
       bundler (~> 1.0)
10 9
       git (>= 1.2.5)
11 10
       rake
12  
-    linecache19 (0.5.12)
13  
-      ruby_core_source (>= 0.1.4)
  11
+    linecache (0.46)
  12
+      rbx-require-relative (> 0.0.4)
14 13
     rake (0.9.2.2)
  14
+    rbx-require-relative (0.0.5)
  15
+    rcov (0.9.11)
15 16
     rspec (2.8.0)
16 17
       rspec-core (~> 2.8.0)
17 18
       rspec-expectations (~> 2.8.0)
@@ -20,16 +21,11 @@ GEM
20 21
     rspec-expectations (2.8.0)
21 22
       diff-lcs (~> 1.1.2)
22 23
     rspec-mocks (2.8.0)
23  
-    ruby-debug-base19 (0.11.25)
24  
-      columnize (>= 0.3.1)
25  
-      linecache19 (>= 0.5.11)
26  
-      ruby_core_source (>= 0.1.4)
27  
-    ruby-debug19 (0.11.6)
28  
-      columnize (>= 0.3.1)
29  
-      linecache19 (>= 0.5.11)
30  
-      ruby-debug-base19 (>= 0.11.19)
31  
-    ruby_core_source (0.1.5)
32  
-      archive-tar-minitar (>= 0.5.2)
  24
+    ruby-debug (0.10.4)
  25
+      columnize (>= 0.1)
  26
+      ruby-debug-base (~> 0.10.4.0)
  27
+    ruby-debug-base (0.10.4)
  28
+      linecache (>= 0.3)
33 29
 
34 30
 PLATFORMS
35 31
   ruby
@@ -37,5 +33,6 @@ PLATFORMS
37 33
 DEPENDENCIES
38 34
   jeweler
39 35
   rake
  36
+  rcov
40 37
   rspec
41  
-  ruby-debug19
  38
+  ruby-debug
12  Rakefile
@@ -15,18 +15,12 @@ rescue LoadError
15 15
   puts "Jeweler (or a dependency) not available. Install it with: sudo gem install jeweler"
16 16
 end
17 17
 
18  
-require 'spec/rake/spectask'
19  
-Spec::Rake::SpecTask.new(:spec) do |spec|
20  
-  spec.libs << 'lib' << 'spec'
21  
-  spec.spec_files = FileList['spec/**/*_spec.rb']
22  
-end
  18
+require 'rspec/core/rake_task'
  19
+RSpec::Core::RakeTask.new(:spec)
23 20
 
24  
-Spec::Rake::SpecTask.new(:rcov) do |spec|
25  
-  spec.libs << 'lib' << 'spec'
  21
+RSpec::Core::RakeTask.new(:rcov) do |spec|
26 22
   spec.pattern = 'spec/**/*_spec.rb'
27 23
   spec.rcov = true
28 24
 end
29 25
 
30  
-#task :spec => :check_dependencies
31  
-
32 26
 task :default => :spec
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.