Allow settingslogic to open a remote yml file #32

Merged
1 commit merged into from Jan 10, 2012

Conversation

Projects
None yet
1 participant
Contributor

maxwell commented Jan 10, 2012

make File.read OpenURI.open().read. This allows for people to reference a remote settings file, which is really handy when using on Heroku.

This pull request is early, as to get feedback on what the most robust way to continue would be. Any feedback would be much appreciated. I really want it to read from a secured S3 bucket or some other password protected file that I could configure in a single Heroku env config.

@maxwell maxwell make File.read OpenURI.open().read. This allows for people to referen…
…ce a remote settings file, which is really handy when using on heroku.
7fd064a
@ghost

ghost commented Jan 10, 2012

Not a bad idea, no reason not to pull this in. Typically on heroku I like to keep anything sensitive in the config vars. Guess it's all the same.

ghost merged commit 4884d45 into binarylogic:master Jan 10, 2012

Contributor

maxwell commented Jan 10, 2012

Thanks, the use case for this is that I don't want everyone one my team to have the production yml file required on their computers if I can help it. I might expand on this pull request in the future FWIW.

@ghost

ghost commented Jan 10, 2012

Agreed, I actually just merge the config vars into the settings hash at run time. The only people that have access to our heroku app are senior engineers.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment