[BL-302] Updating url to prevent sso login url deprecation warning #304

Franr · 2025-04-26T14:55:24Z

What?

Using the new url to prevent sso login url deprecation warning.
A new toolbox image must be released first: binbashar/le-docker-leverage-toolbox#72

Why?

To prevent login url deprecation warnings

References

#302

Before release

Review the checklist here

Summary by CodeRabbit

New Features
- Updated SSO login to use a configurable start URL, allowing for greater flexibility in SSO provider integration.
Bug Fixes
- Adjusted tests to match the new SSO URL format, ensuring accurate validation of the login process.
Chores
- Increased the minimum required version for the TOOLBOX component.
Tests
- Modified test assertions for command output to be less strict about line positions, improving test robustness.

coderabbitai · 2025-04-26T14:55:31Z

Walkthrough

The changes update the minimum required version for the "TOOLBOX" component in the leverage/__init__.py file from "0.2.0" to "0.2.4". In leverage/container.py, the AWS SSO login URL construction was changed from a hardcoded region-based URL to a configurable SSO start URL from the container's configuration. Corresponding tests were updated to patch and verify the new URL format. Additionally, some test assertions in tests/bats/leverage.bats were relaxed to use partial or regexp line matching instead of fixed index matching.

Changes

File(s)	Change Summary
leverage/init.py	Updated TOOLBOX minimum version from "0.2.0" to "0.2.4".
leverage/container.py	Changed AWS SSO login URL from hardcoded region-based to configurable SSO start URL from config.
tests/test_containers/test_aws.py	Updated SSO login test to patch and assert new dynamic SSO start URL format.
tests/bats/leverage.bats	Modified test assertions to use partial or regexp line matching instead of fixed index matching.

Poem

In the toolbox, a version hops up a notch,
SSO URLs now dance to a config’s watch.
No more hardcoded paths for the bunny to chase,
Each login link finds its own special place.
Tests now patch and check with glee—
🐇 Code keeps hopping, wild and free!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8f5318 and 46d53ed.

📒 Files selected for processing (1)

leverage/__init__.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

leverage/init.py

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: integration_tests_cli_refarch (3.9.15, 1.6.0-0.2.0)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Franr · 2025-04-26T14:55:51Z

leverage/__init__.py

 MINIMUM_VERSIONS = {
    "TERRAFORM": "1.3.5",
-    "TOOLBOX": "0.2.0",
+    "TOOLBOX": "0.2.1",  # we require awscli >= 2.22 now


binbashar/le-docker-leverage-toolbox#72

we need the --use-device-code flag

coveralls · 2025-04-26T14:57:08Z

Pull Request Test Coverage Report for Build 15400906598

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 60.982%

Totals
Change from base Build 14328327159:	0.0%
Covered Lines:	2576
Relevant Lines:	4092

💛 - Coveralls

rodriguez-matias

LGTM

updating url to prevent sso login url deprecation warning

5bc5d96

Franr commented Apr 26, 2025

View reviewed changes

Franr added 4 commits April 26, 2025 11:57

fmt

821d0ef

leave a note but don't force it yet

589485e

version warnings now mess up with indexing

73cb294

fixing regex

c8f5318

Franr self-assigned this Apr 27, 2025

Franr added minor feature labels Apr 27, 2025

rodriguez-matias approved these changes Apr 28, 2025

View reviewed changes

exequielrafaela approved these changes Jun 2, 2025

View reviewed changes

Update __init__.py

46d53ed

Franr merged commit a4609c6 into master Jun 3, 2025
27 checks passed

Franr deleted the new-sso-url branch June 3, 2025 12:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[BL-302] Updating url to prevent sso login url deprecation warning #304

[BL-302] Updating url to prevent sso login url deprecation warning #304

Uh oh!

Franr commented Apr 26, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 26, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Franr Apr 26, 2025

Uh oh!

coveralls commented Apr 26, 2025 •

edited

Loading

Uh oh!

rodriguez-matias left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

[BL-302] Updating url to prevent sso login url deprecation warning #304

[BL-302] Updating url to prevent sso login url deprecation warning #304

Uh oh!

Conversation

Franr commented Apr 26, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What?

Why?

References

Before release

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Franr Apr 26, 2025

Choose a reason for hiding this comment

Uh oh!

coveralls commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 15400906598

Details

💛 - Coveralls

Uh oh!

rodriguez-matias left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Franr commented Apr 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 26, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

coveralls commented Apr 26, 2025 •

edited

Loading