Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#732 Update Travis URL on README #7

Merged
merged 5 commits into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@uilianries
Copy link
Member

uilianries commented Apr 12, 2019

#732 Update Travis URL on README
Signed-off-by: Uilian Ries <uilianries@gmail.com>

@uilianries uilianries requested review from SSE4 and Croydon Apr 12, 2019

Croydon and others added some commits Apr 12, 2019

Add README message detail
Co-Authored-By: uilianries <uilianries@gmail.com>
Only update README when there is a file
Co-Authored-By: uilianries <uilianries@gmail.com>
#732 Update Travis URL function name
- The method is dedicated to README file.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
#732 Rename travis URL file
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@Croydon
Copy link
Member

Croydon left a comment

LGTM

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #7 into master will increase coverage by 0.04%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   74.63%   74.68%   +0.04%     
==========================================
  Files          24       25       +1     
  Lines         615      628      +13     
==========================================
+ Hits          459      469      +10     
- Misses        156      159       +3
Impacted Files Coverage Δ
bincrafters_conventions/bincrafters_conventions.py 76.62% <75%> (-0.06%) ⬇️
...rs_conventions/actions/update_readme_travis_url.py 80% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2c314...4ba0bcc. Read the comment docs.

@Croydon Croydon merged commit 2078a26 into bincrafters:master Apr 12, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.