Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AZP builds when building a Pull Request build #28

Closed
wants to merge 1 commit into from

Conversation

@cqjjjzr
Copy link

commented Oct 4, 2019

When building a PR the BUILD_SOURCEBRANCH is like 'ref/pull/1/merge',
which breaks the build by "too many values to unpack (expected 2)"

See https://dev.azure.com/bincrafters/packages/_build/results?buildId=567

When building a PR the BUILD_SOURCEBRANCH is like 'ref/pull/1/merge',
which breaks the build by "too many values to unpack (expected 2)"
@codecov-io

This comment has been minimized.

Copy link

commented Oct 4, 2019

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files           8        8           
  Lines         194      194           
=======================================
  Hits          191      191           
  Misses          3        3
Impacted Files Coverage Δ
bincrafters/build_shared.py 98.03% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a360938...baa8c00. Read the comment docs.

@Croydon Croydon self-requested a review Oct 4, 2019
@Croydon

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Could you please point me to such a pull request where you noticed that?

@cqjjjzr

This comment has been minimized.

Copy link
Author

commented Oct 4, 2019

Already mentioned in the PR description.

bincrafters/conan-wxwidgets#16

@Croydon

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Sorry, I was mobile earlier

I will review soon. Thanks for contributing 😄

Copy link
Member

left a comment

While this should work right now for wxwidgets, this isn't working with all recipes we already migrated to use conandata.yml.

Recipes won't have a version number included, so we rely on them coming from other sources, for bincrafters this will be in most cases the branch name. Not returning a version here for AZP means that all PRs will fail in the future

@Croydon

This comment has been minimized.

@Croydon Croydon closed this Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.