Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdlog: False reference to fmt #24

Closed
Croydon opened this issue Dec 10, 2017 · 4 comments
Closed

spdlog: False reference to fmt #24

Croydon opened this issue Dec 10, 2017 · 4 comments

Comments

@Croydon
Copy link
Member

Croydon commented Dec 10, 2017

https://github.com/bincrafters/conan-spdlog/blob/4f62824f5294da64d0013dfec9e9950ae54d3a35/conanfile.py#L18

I'm pretty sure that this should be fmt instead of fmtlib.

@solvingj
Copy link
Member

solvingj commented Dec 10, 2017

You are correct, thank you for catching this. The author of fmt suggested we change the package name at the last minute and it looks like we did not catch this.

I will use this opportunity to refresh the spdlog recipe with all the recent standards we've implemented since it was last touched.

@solvingj
Copy link
Member

I have corrected the error, and will now move on to refreshing.

@solvingj
Copy link
Member

solvingj commented Dec 10, 2017

Actually, disregard the bit about refreshing, the rest looks up-to-date. I was looking at a very old commit and I thought i was looking at the latest.

Please let us know if the latest commit works for you.

@Croydon
Copy link
Member Author

Croydon commented Dec 10, 2017

Seems to be fine now, thanks!

@Croydon Croydon closed this as completed Dec 10, 2017
@SSE4 SSE4 added this to DONE in logging libraries Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants