Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bincrafters-conventions: Check if system_requirement can be replaced with Conan package #722

Open
Croydon opened this Issue Apr 7, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@Croydon
Copy link
Member

Croydon commented Apr 7, 2019

I would like the enhance the bincrafters-conventions tool with a check for the recipes:

  • Is it using system_requirements()?
  • If yes, is it installing packages we do created Conan packages for in the meantime?
  • If yes, let the check fail and remind the user to update the recipe to use the Conan package instead of the system_requirement

@Croydon Croydon added the enhancement label Apr 7, 2019

@Croydon Croydon self-assigned this Apr 7, 2019

@Croydon Croydon changed the title bincrafters-conventions: Write check if specific system_requirements can be replaced with existing Conan packages bincrafters-conventions: Check if specific system_requirement can be replaced with Conan package Apr 7, 2019

@Croydon Croydon changed the title bincrafters-conventions: Check if specific system_requirement can be replaced with Conan package bincrafters-conventions: Check if system_requirement can be replaced with Conan package Apr 7, 2019

@uilianries

This comment has been minimized.

Copy link
Member

uilianries commented Apr 10, 2019

It's a nice feature, but I think it's not easy to be implemented. For example, when installing with APT, most of libraries use the name libxxx-dev, but we use only conan-xxx. We will need to verify some chunks to validate the name.

@Croydon

This comment has been minimized.

Copy link
Member Author

Croydon commented Apr 12, 2019

I did not had in mind to automate this, as it is too complex to do such a thing and doesn't justify what we get from it.

But I would implement a search for specific, hard-coded packages if we do have Conan packages for them and users will get a notice that they should probably replace the system_requirement with a Conan requirement.

Workflow for adding new ones to the list could be:

  • whenever anyone of us is replacing a system_requirement with a Conan requirement in a recipe
  • and it isn't already in the list
  • we add it to the list in bincrafters-conventions

It's too annoying that when a package has system_requirements that we would need to go through all them manually and look if we have a Conan package for them.

And not replacing them is also not nice.

@uilianries

This comment has been minimized.

Copy link
Member

uilianries commented Apr 13, 2019

I totally agree and I think it's possible to filter by package name.

I don't have a good how to filter the correct package name. For example, we could install libasound-dev, but our Conan package is alsa. Maybe we could filter by name or even creating a table with most common names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.