Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to the templates #49

Merged
merged 2 commits into from Mar 20, 2019

Conversation

Projects
None yet
4 participants
@madebr
Copy link
Contributor

madebr commented Mar 8, 2019

  • changed include(source_subfolder) to include("${CMAKE_BINARY_DIR}/source_subfolder)") to support package development flow.
  • Remove vim header from conanfiles
  • Conanfiles are not scripts, so remove #!/usr/bin/env python header
  • Added a self.output.info(...) to the installer default to inform the user of the added environment variable.
  • chmod a+x'ed build.py files
Show resolved Hide resolved default/CMakeLists.txt Outdated
@@ -1,7 +1,7 @@
cmake_minimum_required(VERSION 2.8.12)
project(cmake_wrapper)

include(conanbuildinfo.cmake)
include("${CMAKE_BINARY_DIR}/conanbuildinfo.cmake")

This comment has been minimized.

@Croydon

Croydon Mar 8, 2019

Member

I use the package development flow when developing the recipes.
When building, this does not copy the sources from self.source_folder to self.build_folder,
so the include requires an explicit path.

Which work flow to you mean exactly? @madebr

This comment has been minimized.

@madebr

madebr Mar 8, 2019

Author Contributor

https://docs.conan.io/en/latest/developing_packages/package_dev_flow.html

I create a src, bin and pkg folder, and run conan source -sf src, conan install -if bin $PATH_TO_CONAN madebr/testing, conan build -if bin -sf src -bf bin -pf pkg and conan package -if bin -sf src -bf bin -pf pkg while developing the recipe.

Because I can easily remove/change source, build and package folders, cmake must know the correct path.

This comment has been minimized.

@madebr

madebr Mar 8, 2019

Author Contributor

(This is also why caching downloads would be useful)

This comment has been minimized.

@Croydon

Croydon Mar 21, 2019

Member

I still don't understand this to be honest. Conan is already creating build, source, export directories etc. Why can't you just use them?

@SSE4

SSE4 approved these changes Mar 10, 2019

@SSE4

This comment has been minimized.

Copy link
Member

SSE4 commented Mar 20, 2019

@Croydon @uilianries are we good to merge this one?

@uilianries
Copy link
Member

uilianries left a comment

LGTM

@uilianries

This comment has been minimized.

Copy link
Member

uilianries commented Mar 20, 2019

Yes @SSE4

@SSE4 SSE4 merged commit e11e306 into bincrafters:master Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.