This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Change rtorrentscript to use rtxmlrpc #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use pyrocore's rtxmlrpc client instead of xmlrpc The listening port can now be changed even when ENABLE_RPC2=no. Back in October @binhex implemented dynamic port reload. Unfortunately the initial version requires XMLRPC to be exposed to the outside world (i.e., an RPC2 location has to be exposed in NGINX). When ENABLE_RPC2 is disabled the initial version fails to set the new port, thus rTorrent becomes unconnectable. rtxmlrpc on the other hand is able to connect directly to rTorrent's SGCI port (5000) entirely bypassing NGINX. As a bonus the script does not need to be aware of NGINX auth credentials. See also: binhex#124
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pyrocore's rtxmlrpc client instead of xmlrpc
The listening port can now be changed even when ENABLE_RPC2=no.
Back in October @binhex implemented dynamic port reload. Unfortunately
the initial version requires XMLRPC to be exposed to the outside world
(i.e., an RPC2 location has to be exposed in NGINX). When ENABLE_RPC2
is disabled the initial version fails to set the new port, thus
rTorrent becomes unconnectable.
rtxmlrpc on the other hand is able to connect directly to rTorrent's
SGCI port (5000) entirely bypassing NGINX. As a bonus the script does
not need to be aware of NGINX auth credentials.
See also: #124