Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not overwrite server.yaml #166

Closed
waclaw66 opened this issue Mar 14, 2022 · 5 comments
Closed

do not overwrite server.yaml #166

waclaw66 opened this issue Mar 14, 2022 · 5 comments
Labels
🪲 bug Something isn't working server Relates to the main binary (server or client)

Comments

@waclaw66
Copy link
Contributor

Hi,
could you please enhance rpm install script to not overwrite /etc/ntfy/server.yaml configuration. Instead of it create server.rpmnew in the usual way?

Thanks.

@binwiederhier binwiederhier added 🪲 bug Something isn't working server Relates to the main binary (server or client) labels Mar 14, 2022
@binwiederhier
Copy link
Owner

I this that's just config|noreplace in https://github.com/binwiederhier/ntfy/blob/main/.goreleaser.yml#L62 like described here: https://goreleaser.com/customization/nfpm/

I won't be able to test this. Is this correct?

@waclaw66
Copy link
Contributor Author

I think noreplace can be used or specify them according docs...

      # These config files will not be replaced by new versions if they were
      # changed by the user. Corresponds to %config(noreplace).
      config_noreplace_files:
        path/to/local/bar.con: /etc/bar.conf

I can check it if you provide a test rpm for x86_64.

@binwiederhier
Copy link
Owner

Pretty sure that 53e0898 will do it, though can provide a test rpm for you shortly (probably after dinner).

@binwiederhier
Copy link
Owner

nvm, here it is: https://phil.nopaste.net/2w23NWuEDS?d=1&f=ntfy_v1.17.1-next_linux_amd64.rpm&a=yy7uex5F6b

@waclaw66
Copy link
Contributor Author

Works fine now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working server Relates to the main binary (server or client)
Projects
None yet
Development

No branches or pull requests

2 participants