Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages with links not selectable #226

Closed
StoyanDimitrov opened this issue Apr 28, 2022 · 2 comments
Closed

Messages with links not selectable #226

StoyanDimitrov opened this issue Apr 28, 2022 · 2 comments
Labels
🪲 bug Something isn't working in-progress 🏃 I'm working on this right now

Comments

@StoyanDimitrov
Copy link
Contributor

Messages with auto-linked text can not be selected by tap over the text, any text not only link. Tapping over empty area successfully selects message.

@binwiederhier binwiederhier added the 🪲 bug Something isn't working label Apr 29, 2022
@binwiederhier binwiederhier added the in-progress 🏃 I'm working on this right now label Apr 29, 2022
@binwiederhier
Copy link
Owner

Fixed in binwiederhier/ntfy-android@4771ccc

I also tried the link movement method above, which highlights links nicely when they are clicked and allows for long-click options. However, the long click does not work properly because the long-click-select-row logic interferes with it. So for now I won't add this. It'd be nice though to open a menu to "copy" or "open" the link on long click

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working in-progress 🏃 I'm working on this right now
Projects
None yet
Development

No branches or pull requests

2 participants