Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in docs #251

Closed
oddlama opened this issue May 14, 2022 · 2 comments
Closed

Typo in docs #251

oddlama opened this issue May 14, 2022 · 2 comments
Labels
docs Improvements or additions to documentation

Comments

@oddlama
Copy link
Contributor

oddlama commented May 14, 2022

Hi! I've spotted a type in the docs. As I'm not sure what the intended wording is, I'm opening this issue instead of a PR. amd64, armv7, and amd64 should probably not include amd64 twice, you probably meant to write x86 or amd.

ntfy/docs/develop.md

Line 123 in 28f211b

If you want to build the **ntfy binary including web app and docs for all supported architectures** (amd64, armv7, and amd64),

@binwiederhier
Copy link
Owner

Thanks. The intended wording is "arm64". If you like you can create a PR to fix it, or just leave this open and I'll fix it eventually.

@binwiederhier binwiederhier added the docs Improvements or additions to documentation label May 14, 2022
@oddlama
Copy link
Contributor Author

oddlama commented May 14, 2022

Thanks, I'll open a PR soon.

binwiederhier added a commit that referenced this issue May 16, 2022
@binwiederhier
Merge pull request #252 from oddlama/fix-docs-typo
cb768ca 
Fix double listing of amd64 in the docs (Fixes #251)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@binwiederhier @oddlama