Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting.yaml base-url comment might want to refer to iOS notifications #322

Closed
milksteakjellybeans opened this issue Jun 11, 2022 · 3 comments

Comments

@milksteakjellybeans
Copy link

When using the "upstream-base-url" option without using the "base-url" option ntfy serve will output:

if upstream-base-url is set, base-url must also be set

From settings.yaml:

# Public facing base URL of the service (e.g. https://ntfy.sh or https://ntfy.example.com)
# This setting is currently only used by the attachments and e-mail sending feature (outgoing mail only).
#
# base-url:

This^ section may need updating to refer to base-url use as part of the iOS notifications feature, in addition to the mention of attachments and email.

thank you

@milksteakjellybeans milksteakjellybeans changed the title setting.yaml base url comment might need to refer to iOS notifications setting.yaml base url comment might want to refer to iOS notifications Jun 11, 2022
@milksteakjellybeans milksteakjellybeans changed the title setting.yaml base url comment might want to refer to iOS notifications setting.yaml base-url comment might want to refer to iOS notifications Jun 11, 2022
@binwiederhier
Copy link
Owner

Fixed in 41096ef

If you can, why don't you try to create a pull request for things like this (docs updates, simple changes) next time. That'd help me a lot :-) If not, don't worry about it.

Thank you for reporting this (and the other tickets!!)

@milksteakjellybeans
Copy link
Author

sure, I will try to figure it out, I am new to GitHub

@binwiederhier
Copy link
Owner

This will probably help: https://www.youtube.com/watch?v=rgbCcBNZcdQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants