Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore new HTTP Priority header #351

Closed
binwiederhier opened this issue Jul 1, 2022 · 2 comments
Closed

Ignore new HTTP Priority header #351

binwiederhier opened this issue Jul 1, 2022 · 2 comments
Labels
🪲 bug Something isn't working server Relates to the main binary (server or client)

Comments

@binwiederhier
Copy link
Owner

Cloudflare apparently adds a Priority: u=... header to requests, which ntfy rejects with 500 invalid priority (should be a 400). This is a new HTTP standard (https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-priority) that is emerging.

We should ignore header values that start with u=. It is quite unfortunate that the name conflicts like this.
@binwiederhier binwiederhier added 🪲 bug Something isn't working server Relates to the main binary (server or client) labels Jul 1, 2022
@binwiederhier
Copy link
Owner Author

Fixed in 95bd876

@ksurl ksurl mentioned this issue Jul 1, 2022
Closed
@binwiederhier
Copy link
Owner Author

This ticket (#353) has a full dump of the Cloudflare request showing the Priority: u=3 header.

@binwiederhier binwiederhier mentioned this issue Nov 3, 2022
Open
@gusdleon gusdleon mentioned this issue Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪲 bug Something isn't working server Relates to the main binary (server or client)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@binwiederhier