Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Allow per-subscription settings for subscriptions created by apps #355

Closed
opk12 opened this issue Jul 2, 2022 · 4 comments
Closed

Comments

@opk12
Copy link

opk12 commented Jul 2, 2022

When the Matrix client SchildiChat is opened, it creates a subscription in ntfy automatically. A short tap shows a toast message that the subscription was made by SchildiChat, and a long tap allows to delete. So it would be nice if the per-subscription settings introduced in #155 were also available for this one.

@binwiederhier
Copy link
Owner

Whoa. @wunter8 literally just did that in binwiederhier/ntfy-android#37. Though only a subset of settings are available. In fact I don't think any of them (other than display name) are applicable. What setting specifically are you looking for?

@opk12
Copy link
Author

opk12 commented Jul 3, 2022

@binwiederhier Hello, I just started using ntfy and I want to mute the chat notifications for the weekend. Schildi and Element do not implement it yet, but maybe I could do it in ntfy? Thank you for linking the PR from two days ago, I had not seen it and just had a cursory glance.

@binwiederhier
Copy link
Owner

For UnifiedPush, ntfy is the delivery mechanism of messages. Muting a topic in ntfy for a UP topic is not the right way, and similar to just cutting the cord on your TV to turn it off. You are assuming that all messages that chat applications receive at chat messages, which is not correct.

We won't implement anything but the display name for UP subscriptions. Hope you understand. If in the future there are other settings that make sense, we'll make them available too.

@opk12
Copy link
Author

opk12 commented Jul 4, 2022

Yes, the intention is to block all communication (including metadata) as some notifications arise from state changes (such as room invites).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants