Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing slash in base URL matters #370

Closed
tfheen opened this issue Jul 25, 2022 · 2 comments
Closed

Trailing slash in base URL matters #370

tfheen opened this issue Jul 25, 2022 · 2 comments
Labels
🪲 bug Something isn't working server Relates to the main binary (server or client)

Comments

@tfheen
Copy link

tfheen commented Jul 25, 2022

In my iOS app, I have https://example.com set as the base URL for my own server, in the --base-url, I had https://example.com/. It seems like there is no URL normalisation going on, which led to notifications not happening immediately (I presume due to the sha-ing of the ntfy.sh notification channel leading to different results).

It would be useful if the URLs were treated the same instead.
@binwiederhier binwiederhier added 🪲 bug Something isn't working server Relates to the main binary (server or client) labels Jul 26, 2022
@binwiederhier
Copy link
Owner

It would be useful if the URLs were treated the same instead.

Agreed. Should be easy to fix.

@binwiederhier
Copy link
Owner

Fixed in b15ecd7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪲 bug Something isn't working server Relates to the main binary (server or client)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tfheen @binwiederhier