Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow IP CIDRs in visitor-request-limit-exempt-hosts #423

Closed
karmanyaahm opened this issue Oct 3, 2022 · 1 comment · Fixed by #429
Closed

Allow IP CIDRs in visitor-request-limit-exempt-hosts #423

karmanyaahm opened this issue Oct 3, 2022 · 1 comment · Fixed by #429
Labels
enhancement New feature or request server Relates to the main binary (server or client)

Comments

@karmanyaahm
Copy link
Contributor

For example, visitor-request-limit-exempt-hosts=matrix.me.org,1.1.1.1,172.0.18.0/16. Then, all of 172.0.18.0/16 will be exempt in addition to matrix.me.org and 1.1.1.1.

This will help with spantaleev/matrix-docker-ansible-deploy#2135, where there is no way to exempt requests from a whole network.
Is this feature fine with you? If so, I can make a PR within the next few weeks.
@binwiederhier
Copy link
Owner

This looks like a good feature and should be easy enough to implement I think.

@binwiederhier binwiederhier added enhancement New feature or request server Relates to the main binary (server or client) labels Oct 3, 2022
@karmanyaahm karmanyaahm mentioned this issue Oct 5, 2022
Merged
@karmanyaahm karmanyaahm mentioned this issue Nov 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request server Relates to the main binary (server or client)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Exempting IP Ranges karmanyaahm/ntfy
2 participants
@binwiederhier @karmanyaahm