Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid external Google fonts #554

Closed
bt90 opened this issue Dec 23, 2022 · 5 comments
Closed

Avoid external Google fonts #554

bt90 opened this issue Dec 23, 2022 · 5 comments
Labels
docs Improvements or additions to documentation enhancement New feature or request

Comments

@bt90
Copy link
Contributor

bt90 commented Dec 23, 2022

Both https://docs.ntfy.sh/ and the self-hosted instances currently make use of Google Fonts.

At least for users in Germany (and probably the entire EU), this is a potential violation of the GDPR: https://thehackernews.com/2022/01/german-court-rules-websites-embedding.html

Could we bundle them as regular assets instead?

@binwiederhier
Copy link
Owner

Yeah I agree. Good catch.

@binwiederhier binwiederhier added enhancement New feature or request web-app Web app things labels Jan 8, 2023
@clementduveau
Copy link

I investigated this issue:

@binwiederhier
Copy link
Owner

The ntfy web app + website does not include Google Fonts at all.

As you correctly identified, the docs do include Google Fonts. The linked privacy plugin is currently only for sponsors, though it seems entirely possible to do this manually by overriding the fonts block manually. Any volunteers?

See squidfunk/mkdocs-material#739 (comment)

@binwiederhier binwiederhier added docs Improvements or additions to documentation and removed web-app Web app things labels Mar 12, 2023
@ozskywalker
Copy link
Contributor

Have submitted PR #667
Let me know if this is acceptable

@binwiederhier
Copy link
Owner

Done in #667 and #668, will be in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants