Topic Pattern *_ matches everything

[Joe-0237]

🐞 Describe the bug
Any ACL Topic Pattern containing only underscores and stars _ * matches all topics: eg.
_*, *_, _*_*_, __*__, _*_

💻 Components impacted
Server

🔮 Additional context
To reproduce:
with the default permission set to read-write
as an anonymous user
deny access to everyone for *_ ntfy access everyone *_ deny
attempt to subscribe to test

[binwiederhier]

I see. Good catch!

[binwiederhier]

Hopefully fixed in #843

[Joe-0237]

E_* matches any E*
So I guess more generally sections of a patterns containing only _ and * are equivalent to *

I looked at the commit, I'm impressed with the testing, and scared of SQL xD but it does look like you got it, I'm glad we could help each other.

[binwiederhier]

As you saw it uses SQLite's wildcards, so there is not but I can do.

I looked at the commit, I'm impressed with the testing, and scared of SQL

Yeah, ... I was not happy with this complexity-add. I am not loving the wildcard-conversion thingy...