Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user now supports reading password from an env var. #327

Merged
merged 6 commits into from
Jun 20, 2022

Conversation

Kenix3
Copy link
Contributor

@Kenix3 Kenix3 commented Jun 15, 2022

No description provided.

@binwiederhier
Copy link
Owner

@Kenix3 bump. you mentioned you wanted to switch this to NTFY_PASSWORD=... ntfy user add phil.

cmd/user.go Outdated
@@ -137,6 +139,7 @@ Examples:
func execUserAdd(c *cli.Context) error {
username := c.Args().Get(0)
role := auth.Role(c.String("role"))
password := c.String("user")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be "password"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed.

@binwiederhier binwiederhier merged commit 5b68915 into binwiederhier:main Jun 20, 2022
@binwiederhier
Copy link
Owner

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants