Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom intent in broadcast action without JSON #341

Merged

Conversation

wunter8
Copy link
Contributor

@wunter8 wunter8 commented Jun 22, 2022

I noticed you could only change the intent of a broadcast action using the JSON publishing format. This allows you to specify the intent as a key/value pair in the Actions header

@binwiederhier
Copy link
Owner

Good catch. Awesome!

To make it the perfect PR, can you

  • Run make fmt to format the code
  • Add an entry in the releases.md (including a thank you to youself 😄)

@binwiederhier binwiederhier merged commit e8569c6 into binwiederhier:main Jun 23, 2022
@wunter8
Copy link
Contributor Author

wunter8 commented Jun 23, 2022

Oops. Sorry about the formatting. My machine defaults to spaces instead of tabs, so it looked the same on my end, but I see the difference. I'll remember that for the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants