Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix Socket Mode #356

Merged
merged 4 commits into from
Jul 3, 2022
Merged

Unix Socket Mode #356

merged 4 commits into from
Jul 3, 2022

Conversation

koro666
Copy link
Contributor

@koro666 koro666 commented Jul 3, 2022

An attempt at adding an option to control the file mode of the Unix socket.

Copy link
Owner

@binwiederhier binwiederhier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, because it's small. Next time before you make changes, try to discuss it with me first, or even open a ticket so I can comment on it.

server/config.go Show resolved Hide resolved
server/server.go Show resolved Hide resolved
@koro666
Copy link
Contributor Author

koro666 commented Jul 3, 2022

This is fine, because it's small. Next time before you make changes, try to discuss it with me first, or even open a ticket so I can comment on it.

Noted.

I have made the changes in rebase, also changed the flag from UintFlag to IntFlag because it was not being read from server.yml.
Let me know if I should change the default mode as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants