Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: default-user, default-password, default-command #372

Merged

Conversation

wunter8
Copy link
Contributor

@wunter8 wunter8 commented Jul 31, 2022

fixes #360

@codecov-commenter
Copy link

Codecov Report

Merging #372 (613d5d5) into main (28975e9) will decrease coverage by 0.29%.
The diff coverage is 19.23%.

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   66.20%   65.90%   -0.30%     
==========================================
  Files          35       35              
  Lines        3648     3669      +21     
==========================================
+ Hits         2415     2418       +3     
- Misses        889      907      +18     
  Partials      344      344              
Impacted Files Coverage Δ
cmd/subscribe.go 29.29% <0.00%> (-3.80%) ⬇️
client/config.go 73.33% <100.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28975e9...613d5d5. Read the comment docs.

@binwiederhier
Copy link
Owner

Awesome, thank you!

@binwiederhier binwiederhier merged commit 9d0231e into binwiederhier:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default (user|password|command) in client.yml
3 participants