Skip to content

docs for auth query param #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

wunter8
Copy link
Contributor

@wunter8 wunter8 commented Oct 9, 2022

No description provided.

docs/publish.md Outdated
2. Authorization header -> Basic base64(testuser:fakepassword) -> Basic dGVzdHVzZXI6ZmFrZXBhc3N3b3Jk
3. base64(Authorization header) -> base64(Basic dGVzdHVzZXI6ZmFrZXBhc3N3b3Jk) -> QmFzaWMgZEdWemRIVnpaWEk2Wm1GclpYQmhjM04zYjNKaw==
4. remove trailing `=` (if any) -> QmFzaWMgZEdWemRIVnpaWEk2Wm1GclpYQmhjM04zYjNKaw== -> QmFzaWMgZEdWemRIVnpaWEk2Wm1GclpYQmhjM04zYjNKaw
5. add query param to URL -> https://ntfy.sh/topic -> https://ntfy.sh/topic?auth=QmFzaWMgZEdWemRIVnpaWEk2Wm1GclpYQmhjM04zYjNKaw

This comment was marked as resolved.

@codecov-commenter
Copy link

Codecov Report

Base: 66.10% // Head: 66.10% // No change to project coverage 👍

Coverage data is based on head (ca5ec53) compared to base (cbc912d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   66.10%   66.10%           
=======================================
  Files          35       35           
  Lines        3720     3720           
=======================================
  Hits         2459     2459           
  Misses        908      908           
  Partials      353      353           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lexevolution
Copy link

Lexevolution commented Oct 9, 2022

Should this mention that this is also applicable for subscribing to an authenticated topic via websockets? That would probably go in the docs/subscribe/api.md

@binwiederhier
Copy link
Owner

Thank you. I'll modify it a bit, but this looks great!

@binwiederhier binwiederhier merged commit 24940f8 into binwiederhier:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants