Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch message INSERTs #502

Merged
merged 7 commits into from
Nov 17, 2022
Merged

Batch message INSERTs #502

merged 7 commits into from
Nov 17, 2022

Conversation

binwiederhier
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 66.04% // Head: 66.13% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (db9ca80) compared to base (499ac76).
Patch coverage: 74.69% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   66.04%   66.13%   +0.09%     
==========================================
  Files          35       36       +1     
  Lines        3723     3795      +72     
==========================================
+ Hits         2459     2510      +51     
- Misses        910      924      +14     
- Partials      354      361       +7     
Impacted Files Coverage Δ
server/message_cache.go 65.25% <53.65%> (-2.55%) ⬇️
util/batching_queue.go 94.11% <94.11%> (ø)
cmd/serve.go 59.90% <100.00%> (+0.81%) ⬆️
server/config.go 100.00% <100.00%> (ø)
server/server.go 60.02% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binwiederhier binwiederhier changed the title WIP: Batch message INSERTs Batch message INSERTs Nov 16, 2022
Copy link
Sponsor

@nwithan8 nwithan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the new logging messages for every success/failure of adding + processing + pruning every single message in the queue going to bloat your logs?

@binwiederhier
Copy link
Owner Author

Is the new logging messages for every success/failure of adding + processing + pruning every single message in the queue going to bloat your logs?

Anything below INFO logs are not logged by default, only when log-level is DEBUG or TRACE. So I can turn them on and diagnose a little and then turn it off again. The log-level is the only option that can be hot-reloaded from the config without restarting the server. Makes debugging much easier: https://docs.ntfy.sh/config/#debuggingtracing

@binwiederhier binwiederhier merged commit f4daa45 into main Nov 17, 2022
@binwiederhier binwiederhier deleted the async-message-cache branch November 25, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants