Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier #746

Merged
merged 4 commits into from
May 24, 2023
Merged

Add prettier #746

merged 4 commits into from
May 24, 2023

Conversation

nimbleghost
Copy link
Contributor

Adds prettier to npm, plus the relevant make targets.

Created a devDependencies sections for tooling, and moved react-scripts there too, which is the only other non-production dependency.

This PR needs to be rebased or merged with a merge commit into master, so that the .git-blame-ignore-refs file still references a valid commit.

@nimbleghost
Copy link
Contributor Author

nimbleghost commented May 23, 2023

Hmm, depending on what weblate does, perhaps we want to ignore the translations in prettier too. Done

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ffbf288) 65.76% compared to head (a859ed9) 65.76%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #746   +/-   ##
=======================================
  Coverage   65.76%   65.76%           
=======================================
  Files          50       50           
  Lines        7332     7332           
=======================================
  Hits         4822     4822           
  Misses       1725     1725           
  Partials      785      785           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binwiederhier
Copy link
Owner

@nimbleghost Just checking, you didn't change anything but the formatting, right? I'm going through the PR but it doesn't look like it.

@binwiederhier binwiederhier merged commit 2e27f58 into binwiederhier:main May 24, 2023
4 checks passed
@nimbleghost nimbleghost deleted the add-prettier branch May 24, 2023 06:43
@nimbleghost
Copy link
Contributor Author

@binwiederhier Correct, just npm run format in this PR!

@binwiederhier
Copy link
Owner

It's already merged. I do have to check everything even if it's autogenerated. Due diligence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants