Fix refreshing things when permission is granted #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We refreshed some things but not everything, this makes it more responsive if you have the settings page open when granting permissions, for example.
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #791 +/- ##
=======================================
Coverage 65.85% 65.85%
=======================================
Files 53 53
Lines 7646 7646
=======================================
Hits 5035 5035
Misses 1775 1775
Partials 836 836 ☔ View full report in Codecov by Sentry. |
(case: from denied to granted)
binwiederhier
approved these changes
Jun 29, 2023
| "alert_notification_ios_install_required_title": "iOS install required", | ||
| "alert_notification_ios_install_required_description": "Click on the Share icon and Add to Home Screen to enable notifications on iOS", | ||
| "alert_not_supported_title": "Notifications not supported", | ||
| "alert_not_supported_description": "Notifications are not supported in your browser.", | ||
| "alert_not_supported_description": "Notifications are not supported in your browser", | ||
| "alert_not_supported_context_description": "Notifications are only supported over HTTPS. This is a limitation of the <mdnLink>Notifications API</mdnLink>.", |
There was a problem hiding this comment.
Just a small FYI: Every time you update existing translation text, 20-something language files become "out of date". I try to keep language changes to a minimum. It is a balance between making it look right and not annoying the translators too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We refreshed some things but not everything, this makes it more responsive if you have the settings page open when granting permissions, for example.
CleanShot.2023-06-28.at.20.26.11.mp4