Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined Priority header handling #895

Merged
merged 6 commits into from Sep 24, 2023
Merged

Refined Priority header handling #895

merged 6 commits into from Sep 24, 2023

Conversation

binwiederhier
Copy link
Owner

No description provided.

gusdleon and others added 6 commits August 28, 2023 23:20
With these changes, If the web request contains the new Priority header (RFC 9218), The server will ignore it and continue searching for other headers or query parameters.
- Now, only if the header being processed is the "priority" header, the cloudflarePriorityIgnore function is called, solving problems with that header injected by CF
- we make the check with regex now.
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 90.00% and no project coverage change.

Comparison is base (addb5ef) 65.76% compared to head (d556a67) 65.77%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #895   +/-   ##
=======================================
  Coverage   65.76%   65.77%           
=======================================
  Files          53       53           
  Lines        7695     7697    +2     
=======================================
+ Hits         5061     5063    +2     
  Misses       1791     1791           
  Partials      843      843           
Files Changed Coverage Δ
util/util.go 76.73% <ø> (-0.23%) ⬇️
server/util.go 86.07% <90.00%> (+0.74%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binwiederhier binwiederhier merged commit 0f919f3 into main Sep 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants