Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine github extension keys #21

Closed
stain opened this issue Nov 7, 2018 · 4 comments
Closed

Refine github extension keys #21

stain opened this issue Nov 7, 2018 · 4 comments
Labels
discuss Discussion/opinions requested enhancement New feature or request

Comments

@stain
Copy link
Member

stain commented Nov 7, 2018

The github extension is only explained by example.

The two keys github_repository and github_URI are not explained and seem to be partially overlapping. The camel_Case is also inconsistent.

Given that these are URLs I think the extension should support any source control repository, not just github.com, perhaps something like:

"extension_domain":{
  "scm_extension": {
    "scm_repository": "https://github.com/example/repo1",
    "scm_type": "git",
    "scm_branch": "c9ffea0b60fa3bcf8e138af7c99ca141a6b8fb21",
    "scm_path": "workflow/hive-viral-mutation-detection.cwl",
    "scm_preview": "https://github.com/example/repo1/blob/c9ffea0b60fa3bcf8e138af7c99ca141a6b8fb21/workflow/hive-viral-mutation-detection.cwl"
}

Here's how Maven defines it's scm metadata.

@stain stain added the discuss Discussion/opinions requested label Nov 7, 2018
@stain stain changed the title Explain github extension keys Refine github extension keys Nov 7, 2018
@stain
Copy link
Member Author

stain commented Nov 7, 2018

Marked as discuss - we can keep this simple or general (or something in-between)

@stain stain added the enhancement New feature or request label Nov 7, 2018
@mr-c
Copy link
Contributor

mr-c commented Nov 15, 2018

I agree, we shouldn't bake in a commercial third party into the BCO spec/standard

@corburn corburn mentioned this issue Nov 16, 2018
6 tasks
@mr-c mr-c reopened this Nov 17, 2018
@mr-c
Copy link
Contributor

mr-c commented Nov 17, 2018

Thanks for clarifying, @HadleyKing but I think the example should be updated to match Stian's suggestion.

@HadleyKing
Copy link
Contributor

HadleyKing commented Nov 17, 2018

github_extension to scm_extension

  • user_guide.md:520: "github_extension": {

  • extension-github.md:9: "github_extension": {

  • antiviral_resistance_detectionTypeDef.json:23: "github_extension": {

  • HCV1a.json:91: "github_extension": {

  • bco-domains.md:22: "github_extension": {

  • README.md:46: * GitHub extension

  • bco-domains.md:74:* GitHub extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Discussion/opinions requested enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants