Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldc > 1.10 causes segfaults #16063

Merged
merged 2 commits into from Jun 25, 2019
Merged

ldc > 1.10 causes segfaults #16063

merged 2 commits into from Jun 25, 2019

Conversation

dpryan79
Copy link
Contributor

@dpryan79 dpryan79 commented Jun 24, 2019

Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the please review & merge label so other members of the bioconda community can have a look at your PR and either make suggestions or merge it. Note that if you are not already a member of the bioconda project (meaning that you can't add this label), please ping @bioconda/core so that your PR can be reviewed and merged (please note if you'd like to be added to the bioconda project). Please see #15332 for more details.

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

@biocondabot
Copy link
Contributor

biocondabot bot commented Jun 24, 2019

Package(s) built on CircleCI are ready for inspection:

Arch Package Repodata
linux-64 sambamba-0.7.0-h89e63da_1.tar.bz2 repodata.json
osx-64 sambamba-0.7.0-h2097cd2_1.tar.bz2 repodata.json

You may also use conda to install these:

  • For packages in linux-64:
    conda install -c https://62558-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>
    
  • For packages in osx-64:
    conda install -c https://62561-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>
    

Docker image(s) built:

Package Tag Install with docker
sambamba 0.7.0--h89e63da_1
showcurl "https://62558-42372094-gh.circle-artifacts.com/0/tmp/artifacts/images/sambamba%3A0.7.0--h89e63da_1.tar.gz" | gzip -dc | docker load

@dpryan79
Copy link
Contributor Author

Xref: biod/sambamba#393

@dpryan79 dpryan79 added WIP please review & merge set to ask for merge and removed WIP labels Jun 24, 2019
@biocondabot biocondabot bot added this to Ready for Review in Review Jun 25, 2019
@dpryan79
Copy link
Contributor Author

Testing locally with 20 files that caused segfaults in 0.6.9 this seems to solve the problem.

Copy link
Contributor

@bwlang bwlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - bummer about the ldc issue though.
Hopefully that will be addressed upstream

@bwlang bwlang merged commit 8837098 into master Jun 25, 2019
@dpryan79 dpryan79 deleted the sambamba-ldc branch June 25, 2019 13:18
@dpryan79
Copy link
Contributor Author

I get the feeling that the sambamba author is quite involved in the D community, so presumably this is getting kicked upstream :)

@epruesse epruesse removed the please review & merge set to ask for merge label Jun 25, 2019
@biocondabot biocondabot bot removed this from Ready for Review in Review Jun 25, 2019
kpalin pushed a commit to kpalin/bioconda-recipes that referenced this pull request Aug 7, 2019
* ldc > 1.10 causes segfaults

* add license file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants