Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update srnapipe. #19052

Merged
merged 1 commit into from Dec 4, 2019
Merged

Update srnapipe. #19052

merged 1 commit into from Dec 4, 2019

Conversation

@ppouchin
Copy link
Contributor

@ppouchin ppouchin commented Dec 3, 2019

Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the please review & merge label so other members of the bioconda community can have a look at your PR and either make suggestions or merge it.

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

  • @BiocondaBot please update will cause the BiocondaBot to merge the master branch into a PR
  • @BiocondaBot please add label will add the please review & merge label.
  • @BiocondaBot please fetch artifacts will post links to packages and docker containers built by the CI system. You can use this to test packages locally before merging.

For members of the Bioconda project, the following command is also available:

  • @BiocondaBot please merge will cause packages/containers to be uploaded and a PR merged. Someone must approve a PR first! This has the benefit of not wasting CI build time required by manually merging PRs.

If you have questions, please post them in gitter or ping @bioconda/core in a comment (if you are not able to directly ping @bioconda/core then the bot will repost your comment and enable pinging).

@ppouchin ppouchin changed the title Added fonts-conda-ecosystem as a dependency. Update srnapipe. Dec 3, 2019
@ppouchin
Copy link
Contributor Author

@ppouchin ppouchin commented Dec 3, 2019

Apparently, r-ggplot2 doesn't include fonts, so if the OS doesn't provide any, graphs will have empty boxes instead of characters.
Including "fonts-conda-ecosystem" normally solves this.

Edit: I was tired and used the wrong biocondabot command...

Loading

@dpryan79
Copy link
Contributor

@dpryan79 dpryan79 commented Dec 4, 2019

@bioconda-bot please merge

Loading

@BiocondaBot
Copy link
Contributor

@BiocondaBot BiocondaBot commented Dec 4, 2019

I will attempt to upload artifacts and merge this PR. This may take some time, please have patience.

Loading

@BiocondaBot
Copy link
Contributor

@BiocondaBot BiocondaBot commented Dec 4, 2019

I received an error uploading the build artifacts or merging the PR!

Loading

@dpryan79 dpryan79 merged commit 321e179 into bioconda:master Dec 4, 2019
1 check passed
Loading
@ppouchin ppouchin deleted the srnapipe branch Dec 4, 2019
@ppouchin
Copy link
Contributor Author

@ppouchin ppouchin commented Dec 4, 2019

Will this effectively update the package that gets installed through conda install srnapipe?
Apparently, it has already been modified a month ago, but the files on anaconda are still from January...

Loading

@dpryan79
Copy link
Contributor

@dpryan79 dpryan79 commented Dec 4, 2019

Ah, apparently this was blacklisted, which would explain why the bot had an error (I shouldn't have ignored that).

Loading

@dpryan79
Copy link
Contributor

@dpryan79 dpryan79 commented Dec 4, 2019

Can you make a new PR removing this from build-fail-blacklist? Then it will actually get built.

Loading

@ppouchin
Copy link
Contributor Author

@ppouchin ppouchin commented Dec 4, 2019

Ok. Thank you for your help.
Apparently, the pinning for perl was dropped with the last commit and the version it tries to set up is 5.26. However, the tool requires 5.22.
I'll go back to the tests and make a PR for removing this from the blacklist when I get it to work properly.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants