Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyfaidx as it needs setuptools as dependency #31892

Merged
merged 1 commit into from Dec 8, 2021

Conversation

marcelm
Copy link
Contributor

@marcelm marcelm commented Dec 7, 2021

pyfaidx imports pkg_resources and therefore needs setuptools as run dependency. For some reason, conda install pyfaidx on Linux will pull in setuptools, while doing the same on macOS will not, so using pyfaidx on macOS fails (unless some other package happens to pull in setuptools).

This came up while bumping WhatsHap in #31867, where the macOS build fails with ModuleNotFoundError: No module named 'pkg_resources' in pyfaidx/__init__.py.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@BiocondaBot
Copy link
Collaborator

Artifacts built on CircleCI are ready for inspection:

Package(s)
Arch Package Repodata
noarch pyfaidx-0.6.3.1-pyh5e36f6f_1.tar.bz2 repodata.json

You may also use conda to install these:

  • For packages on noarch:
conda install -c https://178223-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>

Container image(s)
Package Tag Install with docker
pyfaidx 0.6.3.1--pyh5e36f6f_1
showcurl -L "https://178223-42372094-gh.circle-artifacts.com/0/tmp/artifacts/images/pyfaidx%3A0.6.3.1--pyh5e36f6f_1.tar.gz" | gzip -dc | docker load

@marcelm
Copy link
Contributor Author

marcelm commented Dec 8, 2021

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Dec 8, 2021
@telatin telatin merged commit d32d9d6 into master Dec 8, 2021
@telatin telatin deleted the pyfaidx-setuptools branch December 8, 2021 09:34
@marcelm
Copy link
Contributor Author

marcelm commented Dec 8, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants