Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

s/BiPy/bipy/g #104

Merged
merged 3 commits into from Feb 25, 2014

Conversation

Projects
None yet
4 participants
Owner

jairideout commented Feb 24, 2014

Fixes #44

:godmode:

Member

Jorge-C commented Feb 24, 2014

👍 looks good.

Does the copyright year have to be updated? I wonder if we could do something like Copyright (c) 2013--, The bipy Developers. and avoid updating it every year. If so, it doesn't have to happen here and I could even issue the PR (super quick change to make).

Owner

jairideout commented Feb 25, 2014

That sounds like a good plan- I'll update this PR

Owner

jairideout commented Feb 25, 2014

Ok, updated

One other thing: the development team is now called The bipy Developers. The casing seems strange to me. What about changing it to something like The bipy developers or bipy development team?

Member

Jorge-C commented Feb 25, 2014

I agree, it looks strange. I like both options, maybe with a slight
preference for bipy development team.
On Feb 25, 2014 7:21 AM, "Jai Ram Rideout" notifications@github.com wrote:

Ok, updated

One other thing: the development team is now called The bipy Developers.
The casing seems strange to me. What about changing it to something like The
bipy developers or bipy development team?


Reply to this email directly or view it on GitHubhttps://github.com/biocore/bipy/pull/104#issuecomment-36011354
.

Owner

jairideout commented Feb 25, 2014

👍 for Copyright (c) 2013--, bipy development team. @gregcaporaso @wasade preferences?

Owner

ElDeveloper commented Feb 25, 2014

👍

Yoshiki Vázquez-Baeza

On Feb 25, 2014, at 7:43 AM, Jai Ram Rideout notifications@github.com wrote:

for Copyright (c) 2013--, bipy development team. @gregcaporaso @wasade preferences?


Reply to this email directly or view it on GitHub.

Owner

gregcaporaso commented Feb 25, 2014

Looks good to me. Ready for merge imo.

Owner

jairideout commented Feb 25, 2014

@gregcaporaso are you wanting to keep Copyright (c) 2013--, The bipy Developers.? Note that I didn't make the change to Copyright (c) 2013--, bipy development team. yet.

Owner

gregcaporaso commented Feb 25, 2014

Oh, sorry. Either of those is fine with me.

On Tue, Feb 25, 2014 at 12:09 PM, Jai Ram Rideout
notifications@github.comwrote:

@gregcaporaso https://github.com/gregcaporaso are you wanting to keep Copyright
(c) 2013--, The bipy Developers.? Note that I didn't make the change to Copyright
(c) 2013--, bipy development team. yet.

Reply to this email directly or view it on GitHubhttps://github.com/biocore/bipy/pull/104#issuecomment-36045340
.

Owner

jairideout commented Feb 25, 2014

Thanks- I'm going to change it to bipy development team since it has a few 👍's

Owner

jairideout commented Feb 25, 2014

Ok, this is ready for final review/merge

Member

Jorge-C commented Feb 25, 2014

👍

@gregcaporaso gregcaporaso added a commit that referenced this pull request Feb 25, 2014

@gregcaporaso gregcaporaso Merge pull request #104 from jrrideout/issue-44
s/BiPy/bipy/g
f78bdc2

@gregcaporaso gregcaporaso merged commit f78bdc2 into biocore:master Feb 25, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment