Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin bioimageio.spec #135

Closed
FynnBe opened this issue Oct 21, 2021 · 6 comments
Closed

pin bioimageio.spec #135

FynnBe opened this issue Oct 21, 2021 · 6 comments

Comments

@FynnBe
Copy link
Member

FynnBe commented Oct 21, 2021

the test failures with the conda package (the latest release is sitll pending) makes me think we should pin bioimageio.spec here. otherwise installing any past version is virtually impossible...

I stumbled over the absence of bioimageio.spec pinning in #134 (comment)_

and after some discussion with @k-dominik came to the conclusion that we should pin bioimageio.spec exactly while in 0.x.x (and afterwards down to minor)

@FynnBe
Copy link
Member Author

FynnBe commented Oct 21, 2021

any objections @oeway @constantinpape ?

@FynnBe
Copy link
Member Author

FynnBe commented Oct 21, 2021

This implies some version bumping here, but ensures (enables really) to build and install any other version than the latest, which is currently only possible if one pins core and spec manually (and gets that magic combination just right)

@constantinpape
Copy link
Contributor

In principle no objections, but I am not sure where you want to pin; in the dependencies in this repository or the ones in the conda-forge feedstock. Or both (and then keep them in sync)?

@FynnBe
Copy link
Member Author

FynnBe commented Oct 21, 2021

here in setup.py and I thought that would sync automatically to conda-forge feedstock from the conda-recipe here no?

@constantinpape
Copy link
Contributor

Ah, indeed it reads from the pip requirements.

@constantinpape
Copy link
Contributor

Will be fixed by #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants