Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upJS widgets: don't bridge via QWidget but via thin QObject instead #25
Conversation
This comment has been minimized.
This comment has been minimized.
|
@PrimozGodec would you have time to have a look at this? |
This comment has been minimized.
This comment has been minimized.
|
Right now I am only on data with my cellphone. I will check it when I come to some wifi. |
kernc
force-pushed the
kernc:thin-qobject
branch
from
df33450
to
271f158
Dec 12, 2016
kernc
force-pushed the
kernc:thin-qobject
branch
from
271f158
to
a6a4056
Dec 21, 2016
This comment has been minimized.
This comment has been minimized.
|
I don't know why |
kernc
force-pushed the
kernc:thin-qobject
branch
from
a6a4056
to
260da0f
Jan 3, 2017
kernc
force-pushed the
kernc:thin-qobject
branch
from
260da0f
to
3e9173e
Jan 3, 2017
This comment has been minimized.
This comment has been minimized.
|
I agree with changes. Everything works fine. I am still trying to find out what is a problem with Travis. It seems that it is not connected with your changes same happened in #26. |
astaric
merged commit 93229f0
into
biolab:master
Feb 13, 2017
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build could not complete due to an error
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kernc commentedDec 5, 2016
Refs: "WebView/WebEngine: don't permit exposing QWidgets" in biolab/orange3#1799