Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace networkx by proprietary data structure and algorithms #115
Conversation
This comment has been minimized.
This comment has been minimized.
|
This looks great - networkx is pretty terrible. However, we should make sure removing networkx doesn't break the Louvain clustering widget. The widget outputs an Orange graph if the addon is available and relies on networkx to compute the clustering. As far as I am aware, that is the only widget in core orange that works like that. |
This comment has been minimized.
This comment has been minimized.
|
I will remove networkx only in the addon. Core widgets can still use it. I believe that some widgets in bioinformatics or single cell use networkx, too. As for outputting data to add-on widgets, I can provide a function to transform networkx graph to the new graph. I guess I will pack the new graph into a separate package. This will allow core and other add-ons to include it as dependency instead of checking (like Louvain) whether the add-on is installed. The package will also be useful when we/I also implement some algorithms on graphs. |
janezd
changed the title
Replace networkx by proprietary data structure and algorithms
[WIP] Replace networkx by proprietary data structure and algorithms
Apr 13, 2019
janezd
force-pushed the
janezd:remove-networkx
branch
5 times, most recently
from
256db32
to
31198e4
Apr 13, 2019
janezd
force-pushed the
janezd:remove-networkx
branch
from
8650ddd
to
e213f2d
Apr 17, 2019
janezd
added some commits
Apr 12, 2019
janezd
force-pushed the
janezd:remove-networkx
branch
4 times, most recently
from
2c5bb73
to
6534dc5
Apr 17, 2019
janezd
added some commits
Apr 17, 2019
janezd
force-pushed the
janezd:remove-networkx
branch
from
294371e
to
863a81f
Apr 19, 2019
janezd
force-pushed the
janezd:remove-networkx
branch
from
863a81f
to
71ec112
Apr 19, 2019
janezd
force-pushed the
janezd:remove-networkx
branch
from
71ec112
to
8d95676
Apr 19, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Apr 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
- Coverage 63.56% 62.14% -1.42%
==========================================
Files 25 29 +4
Lines 2835 2800 -35
==========================================
- Hits 1802 1740 -62
- Misses 1033 1060 +27
Continue to review full report at Codecov.
|
janezd
changed the title
[WIP] Replace networkx by proprietary data structure and algorithms
Replace networkx by proprietary data structure and algorithms
Apr 19, 2019
This comment has been minimized.
This comment has been minimized.
|
I'm merging this. I'd like to have the bulk porting done, and now separately improve individual parts.
|
janezd commentedApr 12, 2019
•
edited
Issue
This add-on uses networkx for
Networkx needs to be replaced with something better and more efficient. A few months ago I looked around and found nothing useful.
Also fixes #24, fixes #104.
Description of changes
This PR implements a new (and quite simple) data structure, based on sparse matrices, and ports the widgets to it.
Includes