Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upSpeed-up layout computation. #47
Conversation
kernc
reviewed
Dec 11, 2017
| @@ -173,7 +173,7 @@ def on_tab_changed(index): | |||
|
|
|||
| self.relayout_button = gui.button(box, self, 'Re-layout', | |||
| callback=self.relayout, autoDefault=False) | |||
| self.view.positionsChanged.connect(lambda _: self.progressbar.advance()) | |||
| self.view.positionsChanged.connect(lambda positions, progress: self.progressbar.set(progress)) | |||
This comment has been minimized.
This comment has been minimized.
thocevar
force-pushed the
thocevar:explorer
branch
from
bae55ad
to
3aad398
Dec 12, 2017
kernc
force-pushed the
thocevar:explorer
branch
from
3aad398
to
bbf2e57
Dec 12, 2017
kernc
force-pushed the
thocevar:explorer
branch
from
bbf2e57
to
12837a3
Dec 12, 2017
This comment has been minimized.
This comment has been minimized.
|
I don't notice much difference but understand it should be there. It works. I made the adaptation of |
kernc
merged commit 01821c8
into
biolab:master
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
thocevar commentedDec 11, 2017
Problem:
Computation of node positions with the Fruchterman-Reingold force-directed layout method presented a bottleneck in the Network Explorer widget.
Solution:
Result:
Continuous drawing of calculated node positions is a new bottleneck. It can be mitigated with the use of callback_rate.