Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWGeoMap: Remove duplicates per doc #165

Merged

Conversation

Projects
None yet
4 participants
@nikicc
Copy link
Contributor

commented Dec 5, 2016

When counting locations each document can contibute at most one for each country desipte how many times the location is repeated inside the document's location attribute.

@codecov-io

This comment has been minimized.

Copy link

commented Dec 5, 2016

Current coverage is 93.80% (diff: 100%)

Merging #165 into master will not change coverage

@@             master       #165   diff @@
==========================================
  Files            29         29          
  Lines          1501       1501          
  Methods           0          0          
  Messages          0          0          
  Branches        276        276          
==========================================
  Hits           1408       1408          
  Misses           52         52          
  Partials         41         41          

Sunburst

Powered by Codecov. Last update 8ef83c4...0c58b5f

@nikicc nikicc force-pushed the nikicc:geomap-remove-duplicate-counts-per-doc branch from 1e0d8ba to 544cb74 Dec 5, 2016

OWGeoMap: Remove duplicates per doc, fixes #164
When counting locations each document can contibute at most one for each country desipte how many times the location is repeated inside the document's location attribute.

@nikicc nikicc force-pushed the nikicc:geomap-remove-duplicate-counts-per-doc branch from 544cb74 to 0c58b5f Dec 5, 2016

@nikicc nikicc changed the title OWGeoMap: Remove duplicates counts per doc, fixes #164 [FIX] OWGeoMap: Remove duplicates per doc, fixes #164 Dec 5, 2016

@nikicc nikicc changed the title [FIX] OWGeoMap: Remove duplicates per doc, fixes #164 [FIX] OWGeoMap: Remove duplicates per doc Dec 5, 2016

@nikicc nikicc added this to the 0.2.2 milestone Dec 5, 2016

@@ -145,12 +146,8 @@ def on_map_change(self, map_code=''):
def on_attr_change(self):
if not self.selected_attr:
return
attr = self.data.domain[self.selected_attr]
self.cc_counts = Counter(chain.from_iterable(

This comment has been minimized.

Copy link
@kernc

kernc Dec 5, 2016

Member

Counter appears to be unused. Deport?

This comment has been minimized.

Copy link
@nikicc

nikicc Dec 5, 2016

Author Contributor

I was too late. Will do it an other time 🙈

This comment has been minimized.

Copy link
@kernc

kernc Dec 5, 2016

Member

No worries. Underline wiggles abound. 😄

@ajdapretnar ajdapretnar merged commit b596667 into biolab:master Dec 5, 2016

3 checks passed

codecov/patch Coverage not affected when comparing 8ef83c4...0c58b5f
Details
codecov/project 93.80% (+0.00%) compared to 8ef83c4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nikicc nikicc deleted the nikicc:geomap-remove-duplicate-counts-per-doc branch Dec 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.