Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixups #171

Merged
merged 2 commits into from Jan 3, 2017

Conversation

Projects
None yet
3 participants
@kernc
Copy link
Member

commented Dec 29, 2016

Check if corpus is None (Pandas-compatible) instead of if corpus. Fix regression biolab/orange3#1843 introuces.

@nikicc

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2017

Looks good to me. Though we should probably also replace importing VariablesListItemView from Orange.widgets.data.owselectcolumns at some time 🙈

@nikicc

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2017

Can you please rebase to the new master? I believe the Wikipedia issues are resolved there.

kernc added some commits Dec 29, 2016

@kernc kernc force-pushed the kernc:fixup branch from de83e52 to f468f5d Jan 3, 2017

@codecov-io

This comment has been minimized.

Copy link

commented Jan 3, 2017

Current coverage is 94.29% (diff: 100%)

Merging #171 into master will not change coverage

@@             master       #171   diff @@
==========================================
  Files            29         29          
  Lines          1508       1508          
  Methods           0          0          
  Messages          0          0          
  Branches        277        277          
==========================================
  Hits           1422       1422          
  Misses           46         46          
  Partials         40         40          

Sunburst

Powered by Codecov. Last update 1692e55...f468f5d

@nikicc nikicc merged commit 46f9b36 into biolab:master Jan 3, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 1692e55...f468f5d
Details
codecov/project 94.29% (+0.00%) compared to 1692e55
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.