Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[FIX] As Timeseries: output None when error #30
Conversation
kernc
reviewed
Dec 15, 2017
| def setUp(self): | ||
| self.widget = self.create_widget(OWTableToTimeseries) # type: OWTableToTimeseries | ||
|
|
||
| def test_nan_timeseries(self): |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jerneju
force-pushed the
jerneju:astimeseries-output-none
branch
2 times, most recently
from
87cb5b9
to
0da573b
Dec 15, 2017
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Dec 18, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 67.18% 67.34% +0.15%
==========================================
Files 7 7
Lines 643 643
Branches 99 99
==========================================
+ Hits 432 433 +1
+ Misses 157 156 -1
Partials 54 54
Continue to review full report at Codecov.
|
jerneju
force-pushed the
jerneju:astimeseries-output-none
branch
from
0da573b
to
e34c47a
Dec 18, 2017
kernc
merged commit e7ccd94
into
biolab:master
Dec 18, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
jerneju
deleted the
jerneju:astimeseries-output-none
branch
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jerneju commentedDec 14, 2017
Issue
When we send data to widget As Timeseries and produce output and then send bad data to this widget error is shown but output stays the same.
Description of changes
Output set to
Nonewhen error is shown.Includes