[FIX][ENH] Travis #34

jerneju · Dec 18, 2017

Issue

Travis does not work.

Description of changes

Doctests are disabled.

Includes

Code changes
Tests
Documentation

codecov-io · Dec 18, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@c12932b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #34   +/-   ##
=========================================
  Coverage          ?   67.02%           
=========================================
  Files             ?        7           
  Lines             ?      643           
  Branches          ?       99           
=========================================
  Hits              ?      431           
  Misses            ?      158           
  Partials          ?       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c12932b...c633e55. Read the comment docs.

kernc · Dec 18, 2017

kernc reviewed Dec 18, 2017

View changes

kernc · Dec 18, 2017

orangecontrib/timeseries/tests/test_doctests.py

@@ -75,5 +75,6 @@ def load_tests(loader, tests, ignore):
    # This follows the load_tests protocol
    # https://docs.python.org/3/library/unittest.html#load-tests-protocol
    import orangecontrib
-    tests.addTests(suite(orangecontrib.timeseries))
+    # TODO:
+    # tests.addTests(suite(orangecontrib.timeseries))


Disagree with this.

rst files fail

Could the failing tests be fixed instead? When I last reviewed them, the failures didn't seem like needing a lot of work.

Sure, I am planning to fix them. But that is the next phase. Wait until this PR is finished.

What about setting up travis integration on your own fork, making it work there and opening a PR when it works?

kernc · Dec 18, 2017

kernc requested changes Dec 18, 2017

View changes

Got some issues with the first commit. Much thanks for tending to this, though! 👍

kernc · Dec 18, 2017

.travis.yml

+        - $HOME/.cache/pip
+        - $HOME/.ccache
+        - $HOME/nltk_data
+        - $TRAVIS_BUILD_DIR/pyqt


This block is not needed.

kernc · Dec 18, 2017

.travis.yml

+        - $TRAVIS_BUILD_DIR/pyqt
+
+before_cache:   # prevent logs from caching
+    - rm -f $HOME/.cache/pip/log/debug.log


One achieves the same with cache: pip: false, or by installing our sw with python setup.py install instead of pip. Try the latter.

kernc · Dec 18, 2017

.travis.yml

    - pip install -U setuptools pip wheel
    - pip install codecov
+    # Gensim (2.2.0) requires numpy>=1.11.3 but cannot update it itself?
+    - pip install -U numpy
+    - mkdir -p /home/travis/.local/share/Orange  # create orange app dir


This is Timeseries and what is this?

kernc · Dec 18, 2017

.travis.yml


 install:
    - travis_wait pip install -e .
+    - source $TRAVIS_BUILD_DIR/.travis/install_pyqt.sh


No. Just pip install PyQt5 AnyQt if they aren't specified as dependencies for some reason. Should pip-install cleanly on Python 3.5.

kernc · Dec 18, 2017

setup.py

+            top_level_dir='.')
+
+    extra_setuptools_args = dict(
+        test_suite='setup.discover_tests'


Is it a problem to always set this, regardless of 'test' in sys.argv? When possible, simplify.

kernc · Dec 18, 2017

doc/scripting.rst

@@ -65,7 +65,7 @@ using :func:`interpolate_timeseries` function:

 >>> interpolated = interpolate_timeseries(data, method='cubic')
 >>> interpolated[7:11].Y
-array([ 151.22663433,  146.80661022,  137.77326894,  127.15995178])
+array([ 151.2271691 ,  146.80723481,  137.77371598,  127.16013142])


Call interpolated[7:11].Y.round(2) to avoid this in future?

Or set np.set_printoptions(precision=1) somewhere at the top.

kernc · Dec 18, 2017

doc/scripting.rst

@@ -146,7 +146,7 @@ We can also output the prediction as a :class:`Timeseries` object:
 [Air passengers (forecast), Air passengers (95%CI low), Air passengers (95%CI high)]
 >>> np.set_printoptions(precision=1)


And then remove it here.

kernc · Dec 18, 2017

kernc reviewed Dec 18, 2017

View changes

kernc · Dec 18, 2017

.travis.yml

@@ -18,11 +18,19 @@ cache:
    ccache: true

 before_install:
+    - source $TRAVIS_BUILD_DIR/.travis/util.sh


kernc · Dec 18, 2017

.travis/util.sh

@@ -0,0 +1,14 @@
+


File no longer used.

kernc · Dec 18, 2017

.travis.yml

+before_script:  # required for widget tests
+    - "export DISPLAY=:99.0"
+    - "sh -e /etc/init.d/xvfb start"
+    - sleep 3 # give xvfb some time to start

 script:
    - coverage run setup.py test


Think you can just do here:

catchsegv xvfb-run -a -s "-screen 0 1280x1024x24" coverage run setup.py test

Then you don't need before_script.

kernc · Dec 18, 2017

.travis.yml

    - pip install -U setuptools pip wheel
    - pip install codecov

 install:
    - travis_wait pip install -e .
+    - pip install PyQt5 AnyQt
+    - python setup.py develop   # assure version.py is present; required for imports


version.py? From this repo? Line not needed?

kernc · Dec 18, 2017

doc/scripting.rst

->>> interpolated[7:11].Y
-array([ 151.22663433,  146.80661022,  137.77326894,  127.15995178])
+>>> interpolated[7:11].Y.round(2)
+array([ 151.2271691 ,  146.80723481,  137.77371598,  127.16013142])


With np.set_printoptions(precision=1) above, shouldn't this repr rounded to 1 decimal?

kernc · Dec 18, 2017

kernc approved these changes Dec 18, 2017

View changes

kernc · Dec 18, 2017

Much thanks!

jerneju force-pushed the jerneju:travis branch 9 times, most recently from 2e130a1 to 4f36e6c Dec 18, 2017

jerneju changed the title ~~[ENH] Travis~~ [FIX][ENH] Travis Dec 18, 2017

jerneju force-pushed the jerneju:travis branch from 5da9a1a to fe03554 Dec 18, 2017

jerneju changed the title ~~[FIX][ENH] Travis~~ [WIP][FIX][ENH] Travis Dec 18, 2017

jerneju force-pushed the jerneju:travis branch 2 times, most recently from 9d0aa3f to 9b69f42 Dec 18, 2017

jerneju changed the title ~~[WIP][FIX][ENH] Travis~~ [FIX][ENH] Travis Dec 18, 2017

jerneju force-pushed the jerneju:travis branch 3 times, most recently from 46f0dad to 44ab914 Dec 18, 2017

jerneju force-pushed the jerneju:travis branch from 44ab914 to c633e55 Dec 18, 2017

kernc merged commit 7490f39 into biolab:master Dec 18, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jerneju deleted the jerneju:travis branch Dec 18, 2017

biolab/orange3-timeseries

Join GitHub today

[FIX][ENH] Travis #34

Conversation

jerneju commented Dec 18, 2017 • edited

Issue

Description of changes

Includes

jerneju force-pushed the jerneju:travis branch 9 times, most recently from 2e130a1 to 4f36e6c Dec 18, 2017

This comment has been minimized.

codecov-io commented Dec 18, 2017 • edited

Codecov Report

jerneju changed the title [ENH] Travis [FIX][ENH] Travis Dec 18, 2017

kernc reviewed Dec 18, 2017 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jerneju force-pushed the jerneju:travis branch from 5da9a1a to fe03554 Dec 18, 2017

jerneju changed the title [FIX][ENH] Travis [WIP][FIX][ENH] Travis Dec 18, 2017

jerneju force-pushed the jerneju:travis branch 2 times, most recently from 9d0aa3f to 9b69f42 Dec 18, 2017

jerneju changed the title [WIP][FIX][ENH] Travis [FIX][ENH] Travis Dec 18, 2017

kernc requested changes Dec 18, 2017 View changes

kernc left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

kernc Dec 18, 2017 • edited

This comment has been minimized.

kernc Dec 18, 2017 • edited

This comment has been minimized.

This comment has been minimized.

kernc reviewed Dec 18, 2017 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jerneju force-pushed the jerneju:travis branch 3 times, most recently from 46f0dad to 44ab914 Dec 18, 2017

jerneju added some commits Dec 18, 2017

jerneju force-pushed the jerneju:travis branch from 44ab914 to c633e55 Dec 18, 2017

kernc approved these changes Dec 18, 2017 View changes

This comment has been minimized.

kernc commented Dec 18, 2017

Hide details View details kernc merged commit 7490f39 into biolab:master Dec 18, 2017 1 check passed

1 check passed

jerneju deleted the jerneju:travis branch Dec 18, 2017

jerneju commented Dec 18, 2017 •

edited

jerneju force-pushed the jerneju:travis branch 9 times, most recently from `2e130a1` to `4f36e6c` Dec 18, 2017

codecov-io commented Dec 18, 2017 •

edited

kernc reviewed Dec 18, 2017

View changes

jerneju force-pushed the jerneju:travis branch from `5da9a1a` to `fe03554` Dec 18, 2017

jerneju force-pushed the jerneju:travis branch 2 times, most recently from `9d0aa3f` to `9b69f42` Dec 18, 2017

kernc requested changes Dec 18, 2017

View changes

kernc Dec 18, 2017 •

edited

kernc Dec 18, 2017 •

edited

kernc reviewed Dec 18, 2017

View changes

jerneju force-pushed the jerneju:travis branch 3 times, most recently from `46f0dad` to `44ab914` Dec 18, 2017

jerneju force-pushed the jerneju:travis branch from `44ab914` to `c633e55` Dec 18, 2017

kernc approved these changes Dec 18, 2017

View changes

kernc merged commit `7490f39` into biolab:master Dec 18, 2017
1 check passed