Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[FIX] Seasonal Adjustment: do not fail on negative values #35
Conversation
kernc
reviewed
Dec 18, 2017
| self.Error.seasonal_decompose_fail(str(ex)) | ||
| adjusted_data = None | ||
|
|
||
| if adjusted_data: |
This comment has been minimized.
This comment has been minimized.
jerneju
force-pushed the
jerneju:seasonaladjustment-negative
branch
from
78dce05
to
872bf73
Dec 18, 2017
This comment has been minimized.
This comment has been minimized.
jerneju
force-pushed the
jerneju:seasonaladjustment-negative
branch
from
872bf73
to
1690378
Dec 18, 2017
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Dec 18, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 67.02% 67.18% +0.15%
==========================================
Files 7 7
Lines 643 643
Branches 99 99
==========================================
+ Hits 431 432 +1
+ Misses 158 157 -1
Partials 54 54
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
Is the accompanying test ever hit on Travis? |
jerneju
force-pushed the
jerneju:seasonaladjustment-negative
branch
from
1690378
to
0f4f18e
Dec 18, 2017
kernc
merged commit 7e3bbcc
into
biolab:master
Dec 18, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
jerneju
deleted the
jerneju:seasonaladjustment-negative
branch
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jerneju commentedDec 18, 2017
Issue
Widget crashes when gets data which cannot be handled.
Description of changes
Error is shown.
Includes