Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign up[FIX] Yahoo! Finance #39
Conversation
jerneju
force-pushed the
jerneju:finance
branch
from
f107ca1
to
6509eb4
Dec 19, 2017
This comment has been minimized.
This comment has been minimized.
|
Granularity, if can't choose it, remove. |
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Dec 19, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 68.01% 68.16% +0.14%
==========================================
Files 7 7
Lines 644 647 +3
Branches 99 99
==========================================
+ Hits 438 441 +3
Misses 153 153
Partials 53 53
Continue to review full report at Codecov.
|
jerneju
force-pushed the
jerneju:finance
branch
from
6509eb4
to
f8c337f
Dec 19, 2017
kernc
reviewed
Dec 19, 2017
| from Orange.data import Domain | ||
| from orangecontrib.timeseries import Timeseries | ||
| from orangecontrib.timeseries.pandas_compat import table_from_frame | ||
|
|
||
|
|
||
| class DataGranularity(Enum): |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jerneju
Dec 19, 2017
Author
Contributor
Yes, it is unused. And method quandl_data is unused as well.
jerneju
force-pushed the
jerneju:finance
branch
3 times, most recently
from
90eae03
to
d0cab2e
Dec 19, 2017
jerneju
changed the title
[WIP][FIX] Yahoo! Finance
[FIX] Yahoo! Finance
Dec 20, 2017
jerneju
force-pushed the
jerneju:finance
branch
from
d0cab2e
to
e4702da
Dec 21, 2017
jerneju
added some commits
Dec 19, 2017
jerneju
force-pushed the
jerneju:finance
branch
from
e4702da
to
5664f60
Dec 21, 2017
kernc
reviewed
Dec 23, 2017
| try: | ||
| from Orange.data.pandas_compat import table_from_frame | ||
| except ImportError: | ||
| log.error("Yahoo Finance requires Orange >= 3.9") |
This comment has been minimized.
This comment has been minimized.
kernc
Dec 23, 2017
Member
Raise RuntimeError. Better not show the widget than to just crash later on.
This comment has been minimized.
This comment has been minimized.
|
Perhaps once this and Datasets PR are merged, you could think of bumping a version. :) |
jerneju
force-pushed the
jerneju:finance
branch
2 times, most recently
from
d49d10f
to
e5b6fe3
Jan 3, 2018
jerneju
force-pushed the
jerneju:finance
branch
from
e5b6fe3
to
641746c
Jan 3, 2018
kernc
merged commit f3f4248
into
biolab:master
Jan 3, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jerneju commentedDec 19, 2017
•
edited
Issue
Fixes #14 .
Description of changes
TODO:
Remove first commit (DataFrametoTablefunction) (waiting biolab/orange3#2836 to be merged).Resolution (granularity): remove or fixremovedThis widget works on only Orange 3.9 or newer.
Includes