[ENH] CredentialManager: Store passwords in System Keyring Services #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.72% (diff: 100%)@@ master #1641 diff @@
==========================================
Files 78 78
Lines 8148 8148
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 7229 7229
Misses 919 919
Partials 0 0
|
nikicc
changed the title
kernc
suggested changes
Oct 7, 2016
|
Short example added. |
kernc
suggested changes
Oct 7, 2016
| keyring.set_password(self.service_name, self.username, value) | ||
|
|
||
| def delete_password(self): | ||
| keyring.delete_password(self.service_name, self.username) |
There was a problem hiding this comment.
Can these methods be replaced with __setattr__, __getattr__, and __delattr__ so the supported interface becomes more like a general secure key-value store?
|
|
||
| class CredentialManager: | ||
| def __init__(self, username): | ||
| """ |
There was a problem hiding this comment.
Class docstring goes outside __init__.
| username: username used for storing a matching password. | ||
|
|
||
| Examples: | ||
| >>> cm = CredentialManager('Foo') |
There was a problem hiding this comment.
cm = CredentialManager('Some Widget')|
|
||
| @property | ||
| def key(self): | ||
| return keyring.get_password(self.service_name, self.username) |
There was a problem hiding this comment.
Should getter return None by default?
kernc
suggested changes
Oct 7, 2016
|
|
||
|
|
||
| class CredentialManager: | ||
| def __init__(self, username): |
There was a problem hiding this comment.
Service name (namespace), not username (key).
nikicc
force-pushed
the
credentials
branch
6 times, most recently
from
b2c0129
to
7fa17a2
Compare
|
@kernc please check again. |
kernc
approved these changes
Oct 7, 2016
Credential Manager is used for safely storing passwords in system's keyring services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credential Manager is used for safely storing passwords in system's keyring services.