Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Travis Trusty #1791

Merged
merged 5 commits into from Dec 9, 2016

Conversation

Projects
None yet
3 participants
@kernc
Copy link
Member

commented Dec 1, 2016

Runs Python 3.5, PyQt 5 tests on Travis Ubuntu 14.04.

Enables code coverage of multiprocessing code.

Implements fix proposed in #1779 (comment) because it didn't work without it. Hopefully closes #1779.

Moves AnyQt PyQt4 importhook into Orange.__init__ for convenience when PyQt5 is available and some single module is run.

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation
@codecov-io

This comment has been minimized.

Copy link

commented Dec 1, 2016

Current coverage is 89.05% (diff: 77.77%)

Merging #1791 into master will increase coverage by 0.02%

@@             master      #1791   diff @@
==========================================
  Files            85         85          
  Lines          9019       9027     +8   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           8030       8039     +9   
+ Misses          989        988     -1   
  Partials          0          0          

Sunburst

Powered by Codecov. Last update c4755ab...e724971

@kernc kernc force-pushed the kernc:travis-trusty branch from ed90573 to b90db35 Dec 1, 2016

@kernc kernc force-pushed the kernc:travis-trusty branch 2 times, most recently from c654ba2 to 37af759 Dec 2, 2016

@kernc

This comment has been minimized.

Copy link
Member Author

commented Dec 2, 2016

@astaric With changes as in 02fa7a6, I can't seem to get this to crash. Thanks.

As to why 2571722 doesn't pick mp parts up, ¯\_(ツ)_/¯

@kernc kernc force-pushed the kernc:travis-trusty branch 2 times, most recently from b85a60b to 9806c55 Dec 9, 2016

kernc added some commits Dec 1, 2016

widget tests: don't tearDown widgets
Replace sip.delete() with sip.setdestroyonexit(False), don't call
OWWidget.onDeleteWidget() ==> Avoid double frees and such.

Also fixes #1779
Report: avoid some JS errors on WebEngine
Such as:

	js: Uncaught TypeError: Cannot read property 'scrollIntoView' of null
	js: Uncaught TypeError: Cannot read property 'id' of undefined
	js: Uncaught TypeError: Cannot set property 'className' of null

@kernc kernc force-pushed the kernc:travis-trusty branch from 9806c55 to e724971 Dec 9, 2016

@astaric astaric merged commit 4071837 into biolab:master Dec 9, 2016

4 of 5 checks passed

codecov/patch 77.77% of diff hit (target 95.00%)
Details
codecov/project 89.05% (+0.02%) compared to c4755ab
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@astaric astaric added this to the 3.3.11 milestone Feb 3, 2017

astaric added a commit that referenced this pull request Feb 3, 2017

Merge pull request #1791 from kernc/travis-trusty
[MAINT] Travis Trusty
(cherry picked from commit 4071837)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.